Fixed #36511 -- Ensured filters came before table in keyboard navigation in admin changelist. #19659
Conversation
There was a problem hiding this comment.
Tested and works well for me
I think this highlights that our mobile design is not great for filters (should perhaps be a section that you can open from the side or a collapsed section at the top) but I think this can be agreed and worked on in a separate ticket 👍
Perhaps taking inspiration from tests.admin_views.test_skip_link_to_content.SeleniumTests.test_use_skip_link_to_content, can you write a test which shows that once we are at the main content of the changelist page, tabbing and confirming what gets focused
cb2a339 to
409bb17
Compare
I'm also unsure about where filters should be placed in the mobile design, and I think this is something that will need to be discussed with the accessibility team. Currently, there are two sidebar like features (model selection and filters), but in the mobile design, the model selection sidebar isn’t supported, and as you mentioned the filter usability isn’t great either. I’ll create an ticket for this later :) |
|
New Accessibility Improvement Project 🎉🎉🎉 |
…ion in admin changelist.
Trac ticket number
ticket-36511
Branch description
With the original HTML structure, accessing the sidebar filter on the changelist page required passing through the entire table element.
While keeping the existing layout, the filter was repositioned to the top within the changelist form container so that accessing the filter element no longer requires passing through the table.
Now, the changelist form container element is navigated in the following order....
sidebar filter -> search -> date hierarchy -> table
Checklist
mainbranch.