Skip to content

Remove Type Hints from CspRenderingTestCase #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Remove Type Hints from CspRenderingTestCase #2144

merged 2 commits into from
Jul 8, 2025

Conversation

andoriyaprashant
Copy link
Member

Description

This PR removes explicit type annotations and unnecessary imports from the CspRenderingTestCase class as suggested in #2087

  • Changes made:
    • Removed all type hints within the CspRenderingTestCase methods (ex - root: Element, namespaces: dict[str, str], etc.).
    • Removed unused cast, Element, and ContextList imports.
    • Preserved all logic and test behavior - only typing-related changes were made.

Fixes # 2087

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

matthiask
matthiask approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly sad, but I have to say it looks less noisy. The annotations for basic functions look good, but cast really doesn't.

@matthiask matthiask merged commit a060c79 into django-commons:main Jul 8, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiask matthiask matthiask approved these changes

@tim-schilling tim-schilling Awaiting requested review from tim-schilling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andoriyaprashant @matthiask
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy