Skip to content

Add show_toolbar_with_docker function for Docker IP handling #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

matthiask
Copy link
Member

@matthiask matthiask commented Jul 8, 2025

  • Introduced a new function, show_toolbar_with_docker, to determine if the toolbar should be displayed when running inside Docker containers.
  • Updated installation documentation to reference the new function for Docker configurations.
  • Added a changelog entry for the new functionality.

Fixes #2113

Co-authored-by: Matthias Kestenholz mk@feinheit.ch

- Introduced a new function, show_toolbar_with_docker, to determine if the toolbar should be displayed when running inside Docker containers.
- Updated installation documentation to reference the new function for Docker configurations.
- Added a changelog entry for the new functionality.

Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
Copy link
Member

@blingblin-g blingblin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the features look great, and having tests included makes it much easier to review thoroughly.
Thank you so much for reviving this PR that had been left unattended for a long time! 👍

@matthiask matthiask merged commit 4056f11 into django-commons:main Jul 8, 2025
25 checks passed
@matthiask matthiask deleted the blingblin-g/main branch July 8, 2025 15:19
@matthiask
Copy link
Member Author

Thank you :)

@matthiask matthiask restored the blingblin-g/main branch July 8, 2025 15:19
@matthiask matthiask deleted the blingblin-g/main branch July 8, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

host.docker.internal DNS lookup causes 15s delay in offline environments
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy