Skip to content

Fixes #2160 -- Corrected links to static files #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

matthiask
Copy link
Member

@matthiask matthiask commented Jul 22, 2025

Description

The JSON serialization used by the new serializable mechanism compressed the StaticFile dataclass down to a single string without an .url attribute. Change the code to use a tuple instead to avoid this problem.

Fixes #2160

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

The JSON serialization used by the new serializable mechanism compressed
the `StaticFile` dataclass down to a single string without an `.url`
attribute. Change the code to use a tuple instead to avoid this problem.
@matthiask matthiask requested a review from tim-schilling July 22, 2025 14:47
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@matthiask matthiask merged commit cda2553 into django-commons:main Jul 22, 2025
25 checks passed
@matthiask matthiask deleted the 2160 branch July 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staticfiles in TemplatesPanel aren't allowing viewing static file content
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy