Skip to content

Ensured that include param is properly underscored #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 14, 2025

Fixes #203
Fixes #871

Description of the Change

include query parameter can be in a different formats like dasherized when JSON_API_FORMAT_FIELD_NAMES is set. In some cases, this was not taken into account when reading the include parameter. I have moved the logic of underscoring into the get_included_resources so it will be correctly processed in all use cases.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk July 14, 2025 13:14
@n2ygk n2ygk merged commit 87108d4 into django-json-api:main Jul 14, 2025
9 checks passed
@sliverc sliverc deleted the includes_formatting branch July 14, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inflection is not performed by AutoPrefetchMixin for included resources Reverse the relationship names in includes
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy