Fix small accessibility issues from #57 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
commented
Jun 5, 2021
| @@ -73,7 +73,8 @@ metrics. | |||
| This is what a metric could look like: | |||
|
|
|||
| .. figure:: _static/screenshot.png | |||
| :alt: Metric example | |||
| :target: _static/screenshot.png | |||
There was a problem hiding this comment.
Note I didn’t test this.
There was a problem hiding this comment.
| @@ -22,6 +22,7 @@ def metrics_view(request, name): | |||
| request, | |||
| "postgres_metrics/table.html", | |||
| { | |||
| "title": metric.label, | |||
There was a problem hiding this comment.
This is probably the most important of all of those fixes, making sure the page <title> is set correctly.
f317114 to
f811d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57 for all the details. Each commit fixes a different issue. I only went for things that felt straightforward enough and didn’t need a lot of back-and-forth.