Switch to Django-defined colors for dark mode support #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bba8266 to
0de0660
Compare
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 280 280
Branches 44 44
=========================================
Hits 280 280 Continue to review full report at Codecov.
|
0de0660 to
938f733
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57 – in particular the dark mode support problem:
This PR addresses this by switching to Django’s custom properties, which will automagically switch to variants that are compatible with dark mode. I’ve kept the previous values as fallbacks, for backwards compatibility with older versions of Django. Note this syntax doesn’t work in IE11 – if you think that’s an issue, we can also add a fallback for that.
Here is the result:
I believe the first 3 colors are the same as before. The last one is a bit of a hack, as I don’t think Django has an "info" color, but their breadcrumb color is intended to work well with both light and dark text.