Alpine: install ca-certificates #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, why not. LGTM, cc @tianon |
xoen
added a commit
to ministryofjustice/analytics-platform-control-panel
that referenced
this pull request
Oct 9, 2017
This required few tweaks to the `Dockerfile` as well: - Added 'ca-certificates' package to docker image so that HTTPS works consistently. - Leveraging Alpine Linux's apk options to uninstall build dependencies after `pip install -r requirements` (gcc, and other stuff only needed to build python binary packages will not be in the running container) - `apk del build-deps` will delete the build dependencies when they're not needed anymore See: * [Problem](docker-library/python#128) * [Solution](docker-library/python#136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109 and hopefully the many related issues.
3.5:
2.7:
(i.e. adds 1.28MB, uncompressed)