Skip to content

alpine: Don't install ca-certificates on Alpine 3.7+ #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2018
Merged

alpine: Don't install ca-certificates on Alpine 3.7+ #307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93c1436
alpine: Don't install ca-certificates on Alpine 3.7+
JayH5 Jul 10, 2018
cc8d232
Adjust implementation for smaller diff from existing (keeping "ca-cer…
tianon Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust implementation for smaller diff from existing (keeping "ca-cer… 
…tificates" installed and removing "libressl" after downloading)
  • Loading branch information
@tianon
tianon committed Jul 25, 2018
commit cc8d2323a87f82ab67a982ee00eca1a3a463d18e
8 changes: 6 additions & 2 deletions 2.7/alpine3.6/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,16 @@ ENV LANG C.UTF-8
# https://github.com/docker-library/python/issues/147
ENV PYTHONIOENCODING UTF-8

# install libressl so that HTTPS works on Alpine <3.7
RUN apk add --no-cache libressl
# install ca-certificates so that HTTPS works consistently (other runtime dependencies for Python are installed later); only needed on Alpine 3.6 (3.7+ includes these in the base)
RUN apk add --no-cache ca-certificates

ENV GPG_KEY C01E1CAD5EA2C4F0B8E3571504C367C218ADD4FF
ENV PYTHON_VERSION 2.7.15

RUN set -ex \
&& apk add --no-cache --virtual .fetch-deps \
gnupg \
libressl \
tar \
xz \
\
Expand All @@ -46,6 +47,7 @@ RUN set -ex \
gcc \
gdbm-dev \
libc-dev \
libressl \
libressl-dev \
linux-headers \
make \
Expand Down Expand Up @@ -93,6 +95,8 @@ RUN set -ex \
ENV PYTHON_PIP_VERSION 18.0

RUN set -ex; \
\
apk add --no-cache --virtual .fetch-deps libressl; trap 'apk del .fetch-deps' EXIT; \
\
wget -O get-pip.py 'https://bootstrap.pypa.io/get-pip.py'; \
\
Expand Down
3 changes: 0 additions & 3 deletions 2.7/alpine3.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ ENV LANG C.UTF-8
# https://github.com/docker-library/python/issues/147
ENV PYTHONIOENCODING UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY C01E1CAD5EA2C4F0B8E3571504C367C218ADD4FF
ENV PYTHON_VERSION 2.7.15

Expand Down
3 changes: 0 additions & 3 deletions 2.7/alpine3.8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ ENV LANG C.UTF-8
# https://github.com/docker-library/python/issues/147
ENV PYTHONIOENCODING UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY C01E1CAD5EA2C4F0B8E3571504C367C218ADD4FF
ENV PYTHON_VERSION 2.7.15

Expand Down
3 changes: 0 additions & 3 deletions 3.4/alpine3.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 97FC712E4C024BBEA48A61ED3A5CA953F73C700D
ENV PYTHON_VERSION 3.4.8

Expand Down
3 changes: 0 additions & 3 deletions 3.4/alpine3.8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 97FC712E4C024BBEA48A61ED3A5CA953F73C700D
ENV PYTHON_VERSION 3.4.8

Expand Down
3 changes: 0 additions & 3 deletions 3.5/alpine3.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 97FC712E4C024BBEA48A61ED3A5CA953F73C700D
ENV PYTHON_VERSION 3.5.5

Expand Down
3 changes: 0 additions & 3 deletions 3.5/alpine3.8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 97FC712E4C024BBEA48A61ED3A5CA953F73C700D
ENV PYTHON_VERSION 3.5.5

Expand Down
8 changes: 6 additions & 2 deletions 3.6/alpine3.6/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,16 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
RUN apk add --no-cache libressl
# install ca-certificates so that HTTPS works consistently (other runtime dependencies for Python are installed later); only needed on Alpine 3.6 (3.7+ includes these in the base)
RUN apk add --no-cache ca-certificates

ENV GPG_KEY 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
ENV PYTHON_VERSION 3.6.6

RUN set -ex \
&& apk add --no-cache --virtual .fetch-deps \
gnupg \
libressl \
tar \
xz \
\
Expand All @@ -46,6 +47,7 @@ RUN set -ex \
gdbm-dev \
libc-dev \
libffi-dev \
libressl \
libressl-dev \
linux-headers \
make \
Expand Down Expand Up @@ -104,6 +106,8 @@ RUN cd /usr/local/bin \
ENV PYTHON_PIP_VERSION 18.0

RUN set -ex; \
\
apk add --no-cache --virtual .fetch-deps libressl; trap 'apk del .fetch-deps' EXIT; \
\
wget -O get-pip.py 'https://bootstrap.pypa.io/get-pip.py'; \
\
Expand Down
3 changes: 0 additions & 3 deletions 3.6/alpine3.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
ENV PYTHON_VERSION 3.6.6

Expand Down
3 changes: 0 additions & 3 deletions 3.6/alpine3.8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
ENV PYTHON_VERSION 3.6.6

Expand Down
3 changes: 0 additions & 3 deletions 3.7/alpine3.7/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
ENV PYTHON_VERSION 3.7.0

Expand Down
3 changes: 0 additions & 3 deletions 3.7/alpine3.8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl

ENV GPG_KEY 0D96DF4D4110E5C43FBFB17F2D347EA6AA65421D
ENV PYTHON_VERSION 3.7.0

Expand Down
8 changes: 6 additions & 2 deletions Dockerfile-alpine.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ ENV PATH /usr/local/bin:$PATH
# > At the moment, setting "LANG=C" on a Linux system *fundamentally breaks Python 3*, and that's not OK.
ENV LANG C.UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl
# install ca-certificates so that HTTPS works consistently (other runtime dependencies for Python are installed later); only needed on Alpine 3.6 (3.7+ includes these in the base)
RUN apk add --no-cache ca-certificates

ENV GPG_KEY %%PLACEHOLDER%%
ENV PYTHON_VERSION %%PLACEHOLDER%%

RUN set -ex \
&& apk add --no-cache --virtual .fetch-deps \
gnupg \
libressl \
tar \
xz \
\
Expand All @@ -41,6 +42,7 @@ RUN set -ex \
libc-dev \
libffi-dev \
libnsl-dev \
libressl \
libressl-dev \
libtirpc-dev \
linux-headers \
Expand Down Expand Up @@ -100,6 +102,8 @@ RUN cd /usr/local/bin \
ENV PYTHON_PIP_VERSION %%PLACEHOLDER%%

RUN set -ex; \
\
apk add --no-cache --virtual .fetch-deps libressl; trap 'apk del .fetch-deps' EXIT; \
\
wget -O get-pip.py 'https://bootstrap.pypa.io/get-pip.py'; \
\
Expand Down
8 changes: 6 additions & 2 deletions Dockerfile-caveman-alpine.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@ ENV LANG C.UTF-8
# https://github.com/docker-library/python/issues/147
ENV PYTHONIOENCODING UTF-8

# install libressl so that HTTPS works on Alpine <3.7
# RUN apk add --no-cache libressl
# install ca-certificates so that HTTPS works consistently (other runtime dependencies for Python are installed later); only needed on Alpine 3.6 (3.7+ includes these in the base)
RUN apk add --no-cache ca-certificates

ENV GPG_KEY %%PLACEHOLDER%%
ENV PYTHON_VERSION %%PLACEHOLDER%%

RUN set -ex \
&& apk add --no-cache --virtual .fetch-deps \
gnupg \
libressl \
tar \
xz \
\
Expand All @@ -41,6 +42,7 @@ RUN set -ex \
gdbm-dev \
libc-dev \
libnsl-dev \
libressl \
libressl-dev \
libtirpc-dev \
linux-headers \
Expand Down Expand Up @@ -89,6 +91,8 @@ RUN set -ex \
ENV PYTHON_PIP_VERSION %%PLACEHOLDER%%

RUN set -ex; \
\
apk add --no-cache --virtual .fetch-deps libressl; trap 'apk del .fetch-deps' EXIT; \
\
wget -O get-pip.py 'https://bootstrap.pypa.io/get-pip.py'; \
\
Expand Down
15 changes: 10 additions & 5 deletions update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,17 @@ for version in "${versions[@]}"; do
wheezy) sed -ri -e 's/dpkg-architecture --query /dpkg-architecture -q/g' "$dir/Dockerfile" ;;
esac

if [[ "$v" == alpine* ]] && [ "$v" != 'alpine3.6' ]; then
# https://github.com/docker-library/python/pull/307
# on Alpine 3.6 it's necessary to install libressl to get working HTTPS with wget (and ca-certificates for Python's runtime), but later versions don't require this (support for both is baked into the base)
sed -ri -e '/(libressl|openssl|ca-certificates)([ ;]|$)/d' "$dir/Dockerfile"

# remove any double-empty (or double-empty-continuation) lines the above created
uniq "$dir/Dockerfile" > "$dir/Dockerfile.new"
mv "$dir/Dockerfile.new" "$dir/Dockerfile"
fi

case "$version/$v" in
# On Alpine 3.6 it's necessary to install libressl to get working HTTPS.
# Later Alpine versions have CA certificates pre-installed.
*/alpine3.6)
sed -ri -e '/^# .* libressl$/s/^# //' "$dir/Dockerfile"
;;& # (other patches needed for Alpine 3.6 in later blocks)
# https://bugs.python.org/issue32598 (Python 3.7.0b1+)
# TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL 2.6.x in Alpine 3.7 doesn't implement
# Python 3.5 on Alpine 3.8 needs OpenSSL too
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy