Add libbz2-dev to buildDeps #41
Conversation
| @@ -19,7 +19,7 @@ ENV PYTHON_VERSION 3.4.3 | |||
| RUN gpg --keyserver pool.sks-keyservers.net --recv-keys 97FC712E4C024BBEA48A61ED3A5CA953F73C700D | |||
|
|
|||
| RUN set -x \ | |||
| && buildDeps='curl gcc libc6-dev libsqlite3-dev libssl-dev make xz-utils zlib1g-dev' \ | |||
| && buildDeps='curl gcc libc6-dev libsqlite3-dev libssl-dev make xz-utils zlib1g-devi libbz2-dev' \ | |||
There was a problem hiding this comment.
devi? 👍
(you must be a Vim user! 😄)
Also, worth noting that these are sorted alphabetically. 😉
|
You've tested to make sure this actually fixes #39, right, and aren't just taking our word that it's probably the right fix? 😄 |
|
(and yeah, adding a test to verify this in the future too to the official images tests would be a good idea, but orthogonal) |
|
@tianon yeah vim user. Sorry about that typo :) I'll address your comments later today. Oh, and yes I've verified it actually fixes the issue because I've bumped into it myself, and after adding this it worked. I actually ended up "vendoring in" the slim Dockerfile for starters and wanted to fix it properly so I saw that someone else already opened the issue. |
|
I should mention that I used the 2.7 version. |
|
Cool, sounds good 👍 Just give a shout when you've got the fixes in. 😄 |
|
@tianon @yosifkit updated! I will add tests in a separate PR for docker-library/official-images#560 |
|
LGTM |
1 similar comment
|
LGTM |
- `django`: 1.8 - `php`: empty `*-enabled` folders (docker-library/php#78) - `python`: fix `bz2` module in slim variants (docker-library/python#41)
- `django`: 1.8 - `php`: empty `*-enabled` folders (docker-library/php#78) - `python`: fix `bz2` module in slim variants (docker-library/python#41)
Closes #39
@tianon @yosifkit I'm not sure what to do about the tests ... that's mentioned in the original issue. Is this good to go as is? (and then refactor the tests as needed?)