Install explicit version of "pip" #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,9 @@ RUN gpg --keyserver ha.pool.sks-keyservers.net --recv-keys C01E1CAD5EA2C4F0B8E35 | |||
|
|
|||
| ENV PYTHON_VERSION 2.7.9 | |||
|
|
|||
| # if this is called "PIP_VERSION", pip explodes with "ValueError: invalid truth value '<VERSION>'" | |||
| ENV _PIP_VERSION 6.1.1 | |||
There was a problem hiding this comment.
I would maybe have preferred naming it something less awkward like DOCKER_PIP_VERSION or PYTHON_PIP_VERSION.
There was a problem hiding this comment.
That's definitely easy to change. 👍
There was a problem hiding this comment.
Otherwise this PR looks solid to me 👍
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
May 19, 2015
Install explicit version of "pip"
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
May 19, 2015
- `cassandra`: 2.0.15 - `java`: 8u45-b14-3 - `mongo`: 2.6.10 - `python`: explicit version of `pip` (docker-library/python#46)
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
May 19, 2015
- `cassandra`: 2.0.15, switch to archive.apache.org (docker-library/cassandra#3) - `java`: 8u45-b14-3 - `mongo`: 2.6.10 - `python`: explicit version of `pip` (docker-library/python#46)
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `cassandra`: 2.0.15, switch to archive.apache.org (docker-library/cassandra#3) - `java`: 8u45-b14-3 - `mongo`: 2.6.10 - `python`: explicit version of `pip` (docker-library/python#46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.