Skip to content

Remove coreutils package from Alpine build dependencies #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Remove coreutils package from Alpine build dependencies #697

merged 1 commit into from
Feb 10, 2022

Conversation

felipecrs
Copy link
Contributor

Because I think that it's not needed.

Refs hassio-addons/addon-base-python#102
Refs hassio-addons/addon-base-python#103

@felipecrs
Copy link
Contributor Author

felipecrs commented Feb 9, 2022

Build works in myn local as before, but I suppose the CI can answer this question as well, so I would appreciate if someone could approve it so that the CI runs.

@felipecrs felipecrs changed the title Remove coreutils package from build dependencies Remove coreutils package from Alpine build dependencies Feb 9, 2022
@tianon
Copy link
Member

tianon commented Feb 10, 2022

Ah, this is a historical quirk! It used to be that BusyBox (and thus Alpine) didn't include nproc, so we had to install coreutils for it (or use getconf _NPROCESSORS_ONLN). At some point that changed, and busybox now includes an nproc implementation! 😄 🥳

@tianon tianon merged commit be26fbe into docker-library:master Feb 10, 2022
@felipecrs felipecrs deleted the remove-coreutils branch February 10, 2022 20:44
@felipecrs
Copy link
Contributor Author

Awesome! Thank you!

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 10, 2022
Changes:

- docker-library/python@be26fbe: Merge pull request docker-library/python#697 from felipecrs/remove-coreutils
- docker-library/python@597b1f2: Remove coreutils package from build dependencies
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 23, 2022
Changes:

- docker-library/python@428fed6: Merge pull request docker-library/python#700 from infosiftr/pip-no-compile
- docker-library/python@f42cd53: Set PYTHONDONTWRITEBYTECODE and use "--no-compile" during pip install/test
- docker-library/python@be26fbe: Merge pull request docker-library/python#697 from felipecrs/remove-coreutils
- docker-library/python@597b1f2: Remove coreutils package from build dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy