Skip to content

Switch to multi-line GITHUB_OUTPUT #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Switch to multi-line GITHUB_OUTPUT #852

merged 1 commit into from
Jul 18, 2023

Conversation

tianon
Copy link
Member

@tianon tianon commented Jul 17, 2023 •
edited
Loading

GitHub's being weird about our single-line GITHUB_OUTPUT now, so let's switch to multi-line (which also lets us have a prettier multi-line value, so why not)

We're getting this in multiple places:

Error: Unable to process file command 'output' successfully.
Error: Invalid format 'strategy={"fail-fast":false,"matrix":{"include":[{"name":"3.12.0b4-bookworm","os":"ubuntu-latest","meta":{"entries":[{"name":"3.12.0b4-bookworm","tags":["python:3.12.0b4-bookworm","python:3.12-rc-bookworm","python:3.12.0b4","python:3.12-rc"],"directory":"3.12-rc/bookworm","file":"Dockerfile","builder":"buildkit","constraints":[],"froms":["buildpack-deps:bookworm"]}],"froms":["buildpack-deps:bookworm"],"dockerfiles":["3.12-rc/bookworm/Dockerfile"]},"runs":{"build":"docker buildx build --progress plain --build-arg BUILDKIT_SYNTAX=\"$BASHBREW_BUILDKIT_SYNTAX\" --tag 'python:3.12.0b4-bookworm' --tag 'python:3.12-rc-bookworm' --tag 'python:3.12.0b4' --tag 'python:3.12-rc' '3.12-rc/bookworm'","history":"docker history 'python:3.12.0b4-bookworm'","test":"set -- 'python:3.12.0b4-bookworm'\nif [ -s ./.test/config.sh ]; then set -- --config ~/oi/test/config.sh --config ./.test/config.sh \"$@\"; fi\n~/oi/test/run.sh \"$@\"\naFiles=\"$(docker run --rm 'python:3.12.0b4-bookworm' find /usr/local -name \"*.a\" | tee /dev/stderr)\"; [ -z \"$aFiles\" ]","prepare":"git clone --depth 1 https://github.com/docker-library/official-images.git -b master ~/oi\n# [https://github.com/docker-library/bashbrew/pull/43\nif](https://github.com/docker-library/bashbrew/pull/43/nif) [ -x ~/oi/.bin/bashbrew-buildkit-env-setup.sh ]; then\n\t# [https://github.com/docker-library/official-images/pull/14212\n\tbuildkitEnvs=\](https://github.com/docker-library/official-images/pull/14212/n/tbuildkitEnvs=/)"$(~/oi/.bin/bashbrew-buildkit-env-setup.sh)\"\n\tjq <<<\"$buildkitEnvs\" -r '\n\t\t\tto_entries | map(\n\t\t\t\t(.key | if test(\"[^a-zA-Z0-9_]+\") then\n\t\t\t\t\terror(\"invalid env key: \\(.)\")\n\t\t\t\telse . end)\n\t\t\t\t+ \"=\"\n\t\t\t\t+ (.value | if test(\"[\\r\\n]+\") then\n\t\t\t\t\terror(\"invalid env value: \\(.)\")\n\t\t\t\telse . end)\n\t\t\t) | join(\"\\n\")\n\t\t' | tee -a \"$GITHUB_ENV\"\nelse\n\tBASHBREW_BUILDKIT_SYNTAX=\"$(< ~/oi/.bashbrew-buildkit-syntax)\"; export BASHBREW_BUILDKIT_SYNTAX\n\tprintf \"BASHBREW_BUILDKIT_SYNTAX=%q\\n\" \"$BASHBREW_BUILDKIT_SYNTAX\" >> \"$GITHUB_ENV\"\nfi\n# create a dummy empty image/layer so we can --filter since= later to get a meaningful image list\n{ echo FROM busybox:latest; echo RUN :; } | docker build --no-cache --tag image-list-marker -","pull":"docker pull 'buildpack-deps:bookworm'","images":"docker image ls --filter since=image-list-marker"}},{"name":"3.12.0b4-slim-bookworm","os":"ubuntu-latest","meta":{"entries":[{"name":"3.12.0b4-slim-bookworm","tags":["python:3.12.0b4-slim-bookworm","python:3.12-rc-slim-bookworm","python:3.12.0b4-slim","python:3.12-rc-slim"],"directory":"3.12-rc/slim-bookworm","file":"Dockerfile","builder":"buildkit","constraints":[],"froms":["debian:bookworm-slim"]}],"froms":["debian:bookworm-slim"],"dockerfiles":["3.12-rc/slim-bookworm/Dockerfile"]},"runs":{"build":"docker buildx build --progress plain --build-arg BUILDKIT_SYNTAX=\"$BASHBREW_BUILDKIT_SYNTAX\" --tag 'python:3.12.0b4-slim-bookworm' --tag 'python:3.12-rc-slim-bookworm' --tag 'python:3.12.0b4-slim' --tag 'python:3.12-rc-slim' '3.12-rc/slim-bookworm'","history":"docker history 'python:3.12.0b4-slim-bookworm'","test":"set -- 'python:3.12.0b4-slim-bookworm'\nif [ -s ./.test/config.sh ]; then set -- --config ~/oi/test/config.sh --config ./.test/config.sh \"$@\"; fi\n~/oi/test/run.sh \"$@\"\naFiles=\"$(docker run --rm 'python:3.12.0b4-slim-bookworm' find /usr/local -name \"*.a\" | tee /dev/stderr)\"; [ -z \"$aFiles\" ]","prepare":"git clone --depth 1 https://github.com/docker-library/official-images.git -b master ~/oi\n# [https://github.com/docker-library/bashbrew/pull/43\nif](https://github.com/docker-library/bashbrew/pull/43/nif) [ -x ~/oi/.bin/bashbrew-buildkit-env-setup.sh ]; then\n\t# [https://github.com/docker-library/official-images/pull/14212\n\tbuildkitEnvs=\](https://github.com/docker-library/official-images/pull/14212/n/tbuildkitEnvs=/)"$(~/oi/.bin/bashbrew-buildkit-env-setup.sh)\"\n\tjq <<<\"$buildkitEnvs\" -r '\n\t\t\tto_entries | map(\n\t\t\t\t(.key | if test(\"[^a-zA-Z0-9_]+\") then\n\t\t\t\t\terror(\"invalid env key: \\(.)\")\n\t\t\t\telse . end)\n\t\t\t\t+ \"=\"\n\t\t\t\t+ (.value | if test(\"[\\r\\n]+\") then\n\t\t\t\t\terror(\"invalid env value: \\(.)\")\n\t\t\t\telse . end)\n\t\t\t) | join(\"\\n\")\n\t\t' | tee -a \"$GITHUB_ENV\"\nelse\n\tBASHBREW_BUILDKIT_S

@tianon
Copy link
Member Author

tianon commented Jul 17, 2023

Reproduced, now to debug 🙃

@tianon tianon force-pushed the github-wut branch 5 times, most recently from 08fd5c2 to 14d04b1 Compare July 18, 2023 00:03
@tianon tianon changed the title Debugging GitHub Actions Switch to multi-line GITHUB_OUTPUT Jul 18, 2023
@tianon
Copy link
Member Author

tianon commented Jul 18, 2023

Ok, updated with a proper title/description and commit message.

@tianon tianon marked this pull request as ready for review July 18, 2023 00:04
@tianon tianon mentioned this pull request Jul 18, 2023
Merged
@tianon
Copy link
Member Author

tianon commented Jul 18, 2023

Went a little bit further in docker-library/bashbrew#77

@tianon
Switch to multi-line GITHUB_OUTPUT
5540a45 
GitHub's being weird about our single-line GITHUB_OUTPUT now, so let's switch to multi-line (which also lets us have a prettier multi-line value, so why not)

Also incorporate other GHA improvements from bashbrew example
@yosifkit yosifkit merged commit c2c9e9a into docker-library:master Jul 18, 2023
@yosifkit yosifkit deleted the github-wut branch July 18, 2023 18:33
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jul 22, 2023
@docker-library-bot
Update python
2ebdd14 
Changes:

- docker-library/python@1567851: Update 3.9 to get-pip pypa/get-pip@9af82b7
- docker-library/python@b78f52b: Update 3.8 to get-pip pypa/get-pip@9af82b7
- docker-library/python@eeac281: Update 3.7 to get-pip pypa/get-pip@9af82b7
- docker-library/python@2820ced: Update 3.12-rc to get-pip pypa/get-pip@9af82b7
- docker-library/python@a58630a: Update 3.11 to get-pip pypa/get-pip@9af82b7
- docker-library/python@792cac1: Update 3.10 to get-pip pypa/get-pip@9af82b7
- docker-library/python@35941ad: Merge pull request docker-library/python#851 from infosiftr/get-pip-version
- docker-library/python@4c8b243: Move "get-pip" URL to a separate versions.json section so commits are more clear
- docker-library/python@c2c9e9a: Merge pull request docker-library/python#852 from infosiftr/github-wut
- docker-library/python@5540a45: Switch to multi-line GITHUB_OUTPUT
- docker-library/python@4d12931: Update 3.9
- docker-library/python@aaced40: Update 3.8
- docker-library/python@597175b: Update 3.7
- docker-library/python@b43fc27: Update 3.12-rc
- docker-library/python@1af036f: Update 3.11
- docker-library/python@00dce75: Update 3.10
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 6, 2023
@docker-library-bot
Update python
7ff1412 
Changes:

- docker-library/python@c3f6aa3: Update 3.12-rc to 3.12.0rc1, pip 23.2.1
- docker-library/python@1567851: Update 3.9 to get-pip pypa/get-pip@9af82b7
- docker-library/python@b78f52b: Update 3.8 to get-pip pypa/get-pip@9af82b7
- docker-library/python@eeac281: Update 3.7 to get-pip pypa/get-pip@9af82b7
- docker-library/python@2820ced: Update 3.12-rc to get-pip pypa/get-pip@9af82b7
- docker-library/python@a58630a: Update 3.11 to get-pip pypa/get-pip@9af82b7
- docker-library/python@792cac1: Update 3.10 to get-pip pypa/get-pip@9af82b7
- docker-library/python@35941ad: Merge pull request docker-library/python#851 from infosiftr/get-pip-version
- docker-library/python@4c8b243: Move "get-pip" URL to a separate versions.json section so commits are more clear
- docker-library/python@c2c9e9a: Merge pull request docker-library/python#852 from infosiftr/github-wut
- docker-library/python@5540a45: Switch to multi-line GITHUB_OUTPUT
- docker-library/python@4d12931: Update 3.9
- docker-library/python@aaced40: Update 3.8
- docker-library/python@597175b: Update 3.7
- docker-library/python@b43fc27: Update 3.12-rc
- docker-library/python@1af036f: Update 3.11
- docker-library/python@00dce75: Update 3.10
@yosifkit yosifkit mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianon @yosifkit
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy