refactor: simplify auto header insertion logic #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Koooooo-7
reviewed
Jul 28, 2025
There was a problem hiding this comment.
I think the main.children[0] seems more reasonable/semantic to determine if there contains a Header (although other plugin may broken it, maybe we need distinguish docsify owned doms).
If we change to search h1 in whole content, it seems we breaks the behavior since we don't allow user to use autoHeader for those content which contains h1 for different purpose.
// # AutoHeader add from _sidebar.md
this is a summary for the whole content.
# There is a new section for the next content below
Should I never use the H1 in this content anymore? Maybe we need keep this behavior? or update the docs for the autoHeader, but it will constrict the users' content tho.
- Use querySelector instead of getElementsByTagName for clarity - Avoid redundant DOM wrapping by directly accessing firstElementChild - Add null check to prevent potential DOM insertion errors
57c410c to
b3159b1
Compare
|
Searching for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #810