[DoctrineBundle] Deprecated form types and guessers as services #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeahDude Thanks. Unless you can fix the compatibility issue with symfony 2.3, I am going to hold that PR until EOL of symfony 2.3. |
|
@mikeSimonson No problem :) What is that compatibility issue about ? |
|
Oh ok. I haven't seen the tests :) |
|
The "deprecated" feature was introduced in 2.8 so we have to hold it. Thanks. |
|
Ok actually those ones have some dependencies so we cannot deprecate them. Sorry for the bothering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core form types and guessers are not used as services as of symfony 3.0 and should be removed in 4.0 (ref symfony/symfony#15079).