Skip to content

Move documentation-theme-utils into core #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Move documentation-theme-utils into core #447

merged 1 commit into from
Jun 9, 2016

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Jun 3, 2016

Strategy notes:

  • This will make the documentation-theme-utils module obsolete. The utils it provided were initially intended for HTML themes, but were useful enough that documentation itself had a dependency, and we don't have a sufficient level of pluggability for it to make sense as a module.
  • It also refactors interlinking to make it more flexible and more stable
    • We'll have a linker module that resolves links in a robust way that works with lots of templates
    • And be able to handle custom type links, like if you want Point to go to GeoJSON documentation etc
    • And linking will be more uniform between Markdown and HTML output
  • Functional linker
  • Documentation for helper methods

@codecov-io
Copy link

codecov-io commented Jun 3, 2016

Current coverage is 99.91%

Merging #447 into master will increase coverage by 0.62%

@@             master       #447   diff @@
==========================================
  Files            50         51     +1   
  Lines          1131       1216    +85   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1123       1215    +92   
+ Misses            8          1     -7   
  Partials          0          0          

Powered by Codecov. Last updated by 9bda568...3f08c19

@tmcw tmcw force-pushed the local-util branch 4 times, most recently from b2c321e to ccd96f9 Compare June 8, 2016 14:52
Also:

* Fixes many issues in the default theme
* Moves the default theme from default-theme to default_theme
* Creates a new, robust linker infrastructure that will support
  bare links
* Replaces slugg with github-slugger
* Outputs unknown types as Any. Fixes #451
@tmcw tmcw merged commit 891b06c into master Jun 9, 2016
@tmcw tmcw deleted the local-util branch June 9, 2016 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy