Fix inferring return type of var function #545
Conversation
|
|
||
| // In case of `/** */ var x = function () {}` findTarget returns | ||
| // the declarator. | ||
| if (t.isVariableDeclarator(fn)) { |
There was a problem hiding this comment.
I feel like my change to findTarget might have been bad. However, my other PR makes findTarget return a Path and then it would work to have it return the init again (because paths allows getting the parent).
There was a problem hiding this comment.
I'm not sure, but do you want to update the top-level comment: Infers returns tags by using Flow return type annotations I'm not sure if this comment still applies int he same way.
There was a problem hiding this comment.
It still applies. The purpose of this function is to look at the ast node of the comment and infer the return tag based on the Flow return type annotation.
1d84900 to
2bd59fc
Compare
I accidentally broke the detection of the return type in:
```js
var f = function(x: number): boolean {}
```
2bd59fc to
36610b0
Compare
|
👍 awesome, merging. Trying to pull together a release since there's so much new good work in |
I accidentally broke the detection of the return type in: