Draft grammar to permit nullable types as array element types. #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
reviewed
Mar 19, 2025
| @@ -54,7 +54,8 @@ interface_type | |||
| ; | |||
|
|
|||
| array_type | |||
| : non_array_type rank_specifier+ | |||
| | non_array_type rank_specifier+ | |||
| | non_array_type ( nullable_type_annotation rank_specifier+ )+ | |||
There was a problem hiding this comment.
No, because a nullable type isn't a non_array_type.
There was a problem hiding this comment.
If I'm reading it right, non_array_type includes value_type which includes nullable_value_type which I believe int? would be.
Nigel-Ecma
requested changes
Apr 14, 2025
1 task
jnm2
requested changes
Jul 31, 2025
There was a problem hiding this comment.
We want to wait for a meeting where @gafter is present to discuss this as well, but @jnm2 is keen to get his hands dirty with it when he finds time.
I made it happen! See #1386 for my proposed grammar changes. If we take my PR as the direction, @gafter's other changes in this PR will be valuable to move over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed replacement for #1287
@Nigel-Ecma Can you please help me set up the testing for this PR?