Skip to content

Remove most references to the CLI #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2025

Conversation

RexJaeschke
Copy link
Contributor

This PR address Issue #962.

@RexJaeschke RexJaeschke self-assigned this Jul 12, 2025
@RexJaeschke RexJaeschke added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jul 12, 2025
@RexJaeschke
Copy link
Contributor Author

In response to Nigel's suggestion to make it clear than there is no requirement for a conforming implementation to actually use the CLI, I propose making the following change in Annex C Standard library, C.1 General (see the bold parenthetic sentence):

A conforming C# implementation shall provide a minimum set of types having specific semantics. These types and their members are listed here, in alphabetical order by namespace and type. For a formal definition of the types and their members identified in (§C.2), refer to ISO/IEC 23271:2012 Common Language Infrastructure (CLI), Partition IV; Base Class Library (BCL), Extended Numerics Library, and Extended Array Library, which are included by reference in this specification. (However, this does not require a conforming implementation to actually target the CLI.) For a list of types and their members required beyond those identified in §C.2, see §C.3}}.

@jskeet
Copy link
Contributor

jskeet commented Jul 14, 2025

The proposal sounds good - I'd remove the parentheses though.

Co-authored-by: Kalle Olavi Niemitalo <kon@iki.fi>
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor typo and a suggestion for my meeting action to make it clear that C# adopts some API of, but does not depend on, the CLI.

Otherwise approve.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no additional suggestions.

@Nigel-Ecma Nigel-Ecma self-requested a review July 20, 2025 20:43
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have made my review “Request changes” as it fixes a typo and suggests an alternative approach to the adoption wording, but otherwise approves – and checking “Approve” did the changes. My bad.

To avoid repetition the key comment is this one.

Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
@jskeet jskeet dismissed Nigel-Ecma’s stale review July 30, 2025 20:46

Dismissing as we've accepted the change

@BillWagner BillWagner merged commit ca71330 into dotnet:draft-v8 Jul 30, 2025
6 checks passed
@BillWagner BillWagner deleted the Remove-CLI-refs branch July 30, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy