-
Notifications
You must be signed in to change notification settings - Fork 93
Remove most references to the CLI #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In response to Nigel's suggestion to make it clear than there is no requirement for a conforming implementation to actually use the CLI, I propose making the following change in Annex C Standard library, C.1 General (see the bold parenthetic sentence):
|
The proposal sounds good - I'd remove the parentheses though. |
Co-authored-by: Kalle Olavi Niemitalo <kon@iki.fi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor typo and a suggestion for my meeting action to make it clear that C# adopts some API of, but does not depend on, the CLI.
Otherwise approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no additional suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have made my review “Request changes” as it fixes a typo and suggests an alternative approach to the adoption wording, but otherwise approves – and checking “Approve” did the changes. My bad.
To avoid repetition the key comment is this one.
Co-authored-by: Nigel-Ecma <6654683+Nigel-Ecma@users.noreply.github.com>
Dismissing as we've accepted the change
This PR address Issue #962.