Skip to content

Add DisableThrowNavigationException switch to the server. #49411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ilonatommy
Copy link
Member

For dotnet/aspnetcore#62358.

Defines a switch that can be controlled by BlazorDisableThrowNavigationException property.

@ilonatommy ilonatommy requested a review from javiercn June 16, 2025 09:22
@ilonatommy ilonatommy self-assigned this Jun 16, 2025
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 09:22
@ilonatommy ilonatommy added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Jun 16, 2025
@ilonatommy ilonatommy requested a review from vijayrkn as a code owner June 16, 2025 09:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new runtime host configuration option to control the ThrowNavigationException behavior in Blazor through the BlazorDisableThrowNavigationException property.

  • Introduces a new configuration option in Sdk.Server.targets
  • Allows toggling of navigation exception throwing via a project property
Comments suppressed due to low confidence (1)

src/WebSdk/Web/Targets/Sdk.Server.targets:51

  • [nitpick] Consider adding a brief comment to explain the purpose of the DisableThrowNavigationException switch to improve maintainability and ease of understanding for future developers.
<RuntimeHostConfigurationOption Include="Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException"

Copy link
Contributor

Thanks for your PR, @@ilonatommy.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@ilonatommy ilonatommy requested a review from a team as a code owner June 16, 2025 10:11
@ilonatommy
Copy link
Member Author

/ba-g Failures are not related, they occur on other PRs as well.

@ilonatommy ilonatommy enabled auto-merge June 16, 2025 13:34
@ilonatommy ilonatommy requested a review from akoeplinger June 16, 2025 13:37
@akoeplinger akoeplinger disabled auto-merge June 16, 2025 13:42
@akoeplinger akoeplinger merged commit 50a810c into dotnet:main Jun 16, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy