Support dotnet clean file.cs
#49511
Open
Support dotnet clean file.cs
#49511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the command "dotnet clean file.cs" to clean build artifacts for file-based programs and updates associated tests, command parsing, and documentation.
- Updates test snapshots and schemas for new argument syntax for file-based programs.
- Adds new tests and command paths to verify clean behavior using file-based entry points.
- Enhances the VirtualProjectBuildingCommand with a NoBuildMarkers property and updates CleanCommand/API accordingly.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CompletionTests/snapshots/zsh/DotnetCliSnapshotTests.VerifyCompletions.verified.zsh | Updates command completion text to include file-based programs. |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests for cleaning file-based programs and verifies artifact deletion. |
| test/dotnet.Tests/CommandTests/MSBuild/GivenDotnetCleanInvocation.cs | Updates CleanCommand invocation tests with appropriate casts. |
| test/dotnet.Tests/CliSchemaTests.cs | Adjusts CLI schema to reflect the new argument naming and description. |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Introduces NoBuildMarkers property and conditionally skips writing build markers. |
| src/Cli/dotnet/Commands/Clean/CleanCommandParser.cs | Renames and adjusts arguments for enhanced file-based program support. |
| src/Cli/dotnet/Commands/Clean/CleanCommand.cs | Updates command creation logic and return types for file-based commands. |
| documentation/general/dotnet-run-file.md | Adds documentation for the new "dotnet clean file.cs" behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #48250.