Adds code coverage to StandardMenuStripVerb #13492
Merged
+150
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related dotnet#10773 ## Proposed changes - Adds code coverage to `StandardMenuStripVerb` ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 10.0.100-preview.5.25265.106
There was a problem hiding this comment.
Pull Request Overview
Adds unit tests to improve code coverage of StandardMenuStripVerb, verifying its constructor and item insertion behavior.
- Introduces
StandardMenuStripVerbTestswith extensive Moq setup for designer host and services. - Adds tests for the class constructor and the
InsertItemsmethod.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs:108
- [nitpick] Currently only the constructor and
InsertItemsare verified. Consider adding tests for other behaviors (e.g., error paths, multiple inserts) to fully coverStandardMenuStripVerb.
[WinFormsFact]
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Show resolved
Hide resolved
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Show resolved
Hide resolved
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Show resolved
Hide resolved
LeafShi1
reviewed
May 21, 2025
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13492 +/- ##
===================================================
+ Coverage 76.59683% 76.90004% +0.30321%
===================================================
Files 3230 3263 +33
Lines 639157 643711 +4554
Branches 47295 47638 +343
===================================================
+ Hits 489574 495014 +5440
+ Misses 146007 145024 -983
- Partials 3576 3673 +97
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/StandardMenuStripVerb.cs
Show resolved
Hide resolved
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
LeafShi1
reviewed
Jul 11, 2025
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/StandardMenuStripVerb.cs
Show resolved
Hide resolved
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Show resolved
Hide resolved
LeafShi1
previously approved these changes
Jul 18, 2025
Epica3055
reviewed
Jul 21, 2025
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/StandardMenuStripVerbTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
approved these changes
Aug 1, 2025
Epica3055
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
StandardMenuStripVerbCustomer Impact
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow