Skip to content

Update Microsoft.Extensions.Logging.Console to 5.0.0 #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update Microsoft.Extensions.Logging.Console to 5.0.0 #607

wants to merge 3 commits into from

Conversation

Lucina
Copy link

@Lucina Lucina commented Mar 8, 2021

I have a NuGet dependency that uses Microsoft.Extensions.Logging.Abstractions 5.0.0, scripts using it won't compile due to Dotnet.Script's version differing. 5.0.0 is the latest stable version of the logging packages.

@filipw
Copy link
Member

filipw commented Mar 8, 2021

since we multitarget 3.1 as well, it would make sense to target this only for net5.0?

@Lucina
Copy link
Author

Lucina commented Mar 8, 2021

That makes sense. This second commit conditionally uses 5.0.0 for net5.0 and uses 3.1.12 (update from 3.1.6) for the rest.

@seesharper
Copy link
Collaborator

seesharper commented Mar 8, 2021

I am not completely sure if this is actually necessary. The Microsoft.Extensions.Logging.Consolepackage is not a SDK dependency and the 5.0 version is compatible with netstandard2.0 so there should be no problem using the 5.0 version with a netcoreapp3.1 app. Also we still support netcoreapp2.1 which also can consume this package. It should also be noted that the Microsoft.Extensions.Logging.Console is only used in the the dotnet-script executable and is not shared with OmniSharp. Just want to make sure that this is actually needed before we start to add conditional package references. It is sort of a potential rabbithole 😀

@Lucina
Copy link
Author

Lucina commented Mar 9, 2021

I did notice those TFMs explicitly mentioned in the package dependency list for 5.0.0, but after the reply I thought it might be better to just leave the version as-is but at least update the version for net5.0 just for numerical alignment and to get my scripts to work. My scripts worked on the three builds Dotnet.Script produces using 5.0.0 and without the conditional references, so I'm reverting the conditional commit.

@toras9000
Copy link

I think this update will resolve the Microsoft.Extensions conflict problem when using the net5.0 package.

It can be reproduced with this short script, but EFCore 5.0 is currently unavailable.
(I know 3.1 is available, but 5.0 is preferable.)

#r "nuget: Microsoft.EntityFrameworkCore, 5.0.5"
class MyDbContext : Microsoft.EntityFrameworkCore.DbContext{}
new MyDbContext();

I don't know how it behaves when combined with older runtimes, but I think it would be useful to update it if it doesn't cause any problems.

@seesharper
Copy link
Collaborator

Fixed by #614

@seesharper seesharper closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy