Handle URLs on Duck.ai Input Mode #6416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Duck.ai chat input to detect URLs and switch the submit behavior and icon accordingly.
- Updates ViewModel to change the send icon to a globe for URL inputs and emits distinct commands (
SubmitSearchorSubmitChat) based on content. - Introduces new commands (
SubmitSearch,SubmitChat) and wires them through the Fragment, extracting submission logic into dedicated methods. - Extends the input widget to notify chat text changes and adds corresponding tests in
InputScreenViewModelTest.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| InputScreenViewModel.kt | Added onChatInputTextChanged, onSearchSubmitted, onChatSubmitted methods to handle URL detection and command emission. |
| Command.kt | Defined new SubmitSearch and SubmitChat commands. |
| InputModeWidget.kt | Added onChatTextChanged callback and updated the tab‐based text change handler. |
| InputScreenFragment.kt | Refactored submission setup to call ViewModel, implemented submitSearchQuery and submitChatQuery helpers, and handled new commands. |
| InputScreenViewModelTest.kt | Added tests for globe icon state and correct command emission for both search and chat submissions. |
Comments suppressed due to low confidence (1)
duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt:287
- [nitpick] Add KDoc to public methods like
onChatInputTextChangedto explain their purpose and expected behavior, improving maintainability and easing future onboarding.
fun onChatInputTextChanged(query: String) {
...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/InputModeWidget.kt
Show resolved
Hide resolved
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/InputModeWidget.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210823147637789?focus=true
Description
Steps to test this PR