Skip to content

updates resource output to correctly nest attributes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2015

Conversation

ninjapenguin
Copy link
Contributor

Spec:

"attributes": an "attributes object", providing information about a resource.

See: http://jsonapi.org/format/#document-structure-resource-objects

Spec: "attributes": an "attributes object", providing information about
a resource.

See: http://jsonapi.org/format/#document-structure-resource-objects
@pmccarren
Copy link
Contributor

@ninjapenguin Has json-api/json-api#588 been released yet? My understanding is that master is headed towards rc4, however it's not quite there yet (I could for sure be wrong though :) )
ref: manyminds/api2go#118

@mjanda
Copy link

mjanda commented Jun 24, 2015

Current ember-data (1.13.4) expects this format, so it should be at least optional and mentioned in readme?

@egeriis
Copy link
Owner

egeriis commented Aug 3, 2015

@ninjapenguin Can you create a new pull request which doesn't conflict with master? :) Thanks.

@egeriis
Copy link
Owner

egeriis commented Aug 19, 2015

Now that JSON API v1 has officially been released, it would be great to have this PR merged. @ninjapenguin do you have the time to fix the merge conflict, please?

@egeriis egeriis mentioned this pull request Sep 21, 2015
@egeriis
Copy link
Owner

egeriis commented Sep 21, 2015

@ninjapenguin Desperately pinging you again :)

@ninjapenguin
Copy link
Contributor Author

@egeriis I'll take a look at this and update the PR this weekend!

@egeriis
Copy link
Owner

egeriis commented Sep 22, 2015

That's just awesome @ninjapenguin 👍

@ninjapenguin
Copy link
Contributor Author

@egeriis This now looks fine to me!

egeriis added a commit that referenced this pull request Sep 28, 2015
updates resource output to correctly nest attributes
@egeriis egeriis merged commit 4e5c29c into egeriis:master Sep 28, 2015
@egeriis
Copy link
Owner

egeriis commented Sep 28, 2015

Thank you so much @ninjapenguin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy