Fix tests

electric-sql · alco · Jun 16, 2025 · Jun 9, 2025 · Jun 2, 2025 · Jun 5, 2025
commit 93fbf79f0ec1d94774cf8e0b18a0869b663e6284
diff --git a/packages/sync-service/lib/electric/db_connection_error.ex b/packages/sync-service/lib/electric/db_connection_error.ex
@@ -170,6 +170,20 @@ defmodule Electric.DbConnectionError do
     }
   end
 
+  if Mix.env() == :test do
+    def from_error(:shutdown) do
+      %DbConnectionError{
+        message: "Test database connection has beed shutdown",
+        type: :shutdown,
+        original_error: :shutdown,
+        # We don't want for this error to be treated as fatal because what would interfere with the
+        # supervision startup/shutdown setup in tests. We just treat it as a retryable DB error
+        # and let the test code control supervision tree orchestration.
+        retry_may_fix?: true
+      }
+    end
+  end
+
   def from_error(error), do: unknown_error(error)
 
   def format_original_error(%DbConnectionError{original_error: error}) do

diff --git a/packages/sync-service/test/electric/postgres/lock_connection_test.exs b/packages/sync-service/test/electric/postgres/lock_connection_test.exs
@@ -54,8 +54,9 @@ defmodule Electric.Postgres.LockConnectionTest do
 
       assert_lock_acquired()
 
-      # try to grab the same with another
-      new_stack_id = :"#{stack_id}_new"
+      # try to grab the same lock using a different connection
+      new_stack_id = stack_id <> "_new"
+      _registry = start_link_supervised!({Electric.ProcessRegistry, stack_id: new_stack_id})
 
       assert {:ok, _pid} =
                LockConnection.start_link(

diff --git a/packages/sync-service/test/support/component_setup.ex b/packages/sync-service/test/support/component_setup.ex
@@ -55,7 +55,7 @@ defmodule Support.ComponentSetup do
   end
 
   def with_registry(ctx) do
-    registry_name = :"#{Registry.ShapeChanges}:#{ctx.stack_id}"
+    registry_name = :"#{inspect(Registry.ShapeChanges)}:#{ctx.stack_id}"
     start_link_supervised!({Registry, keys: :duplicate, name: registry_name})
 
     %{registry: registry_name}

diff --git a/packages/sync-service/test/support/test_utils.ex b/packages/sync-service/test/support/test_utils.ex
@@ -37,7 +37,7 @@ defmodule Support.TestUtils do
   end
 
   def full_test_name(ctx) do
-    "#{ctx.module} #{ctx.test}"
+    "#{inspect(ctx.module)} #{ctx.test}"
   end
 
   def ins(opts) do