fix: setContentProtection affects BrowserWindow frame #31768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Nov 9, 2021
zcbenz
approved these changes
Nov 10, 2021
|
Release Notes Persisted
|
This was referenced Nov 15, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31829 |
|
I have automatically backported this PR to "15-x-y", please check out #31830 |
|
I have automatically backported this PR to "14-x-y", please check out #31831 |
|
I have automatically backported this PR to "16-x-y", please check out #31832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31735.
If the layered property is set before setting the affinity, the window frame disappears in some cases. Switching the order solves the issue - I believe this is a Windows bug.
cc @KazuyaHayashi
Checklist
npm testpassesRelease Notes
Notes: Fixed window frame glitch when calling
setContentProtection.