Skip to content

fix: report more detailed errors in shell.openExternal() on Windows #33660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: report more detailed errors in shell.openExternal() on Windows #33660

merged 1 commit into from
Apr 11, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 7, 2022

Backport of #33620

See that PR for details.

Notes: shell.openExternal() now reports more detailed errors on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 7, 2022
@trop trop bot requested a review from miniak April 7, 2022 18:09
@trop trop bot mentioned this pull request Apr 7, 2022
Merged
3 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 7, 2022
@deepak1556 deepak1556 merged commit 11e1408 into 19-x-y Apr 11, 2022
@deepak1556 deepak1556 deleted the trop/19-x-y-bp-fix-report-more-detailed-errors-in-shell-openexternal-on-windows-1649354935466 branch April 11, 2022 19:00
@release-clerk
Copy link

release-clerk bot commented Apr 11, 2022

Release Notes Persisted

shell.openExternal() now reports more detailed errors on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniak @deepak1556
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy