build: add platform-specific conditions to the source_set in chromium_src #47627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! while you are in this file, can you also move electron/chromium_src/BUILD.gn Lines 147 to 148 in 499e987 electron/chromium_src/BUILD.gn Line 271 in 499e987 |
deepak1556
approved these changes
Jul 2, 2025
|
@cucbin would you please rebase this? |
12e6b2b to
004ed7f
Compare
@codebytere done. |
codebytere
approved these changes
Jul 5, 2025
|
@codebytere |
|
Release Notes Persisted
|
georgexu99
pushed a commit
that referenced
this pull request
Jul 16, 2025
…_src (#47627) * build: Add platform-specific if conditions to the source sets in chromium_src. * build: Add platform-specific if conditions to the source sets in chromium_src.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The configuration in chromium_src's BUILD.gn causes Visual Studio's Solution Explorer to display projects and code irrelevant to the current platform.
This occurs because source sets originally intended for Mac-only were incorrectly included.
Checklist
npm testpassesRelease Notes
Notes: Add platform-specific conditions to the source_set in chromium_src