build: cleanup symlinks in cache #47727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jul 11, 2025
codebytere
approved these changes
Jul 11, 2025
e5f4b93 to
f83eb08
Compare
Needed to ignore Dangerous symbolic link path was ignored errors
f83eb08 to
02361df
Compare
This reverts commit 69e53cd.
|
No Release Notes |
This was referenced Jul 11, 2025
|
I have automatically backported this PR to "36-x-y", please check out #47730 |
|
I have automatically backported this PR to "37-x-y", please check out #47731 |
|
I have automatically backported this PR to "35-x-y", please check out #47732 |
|
I have automatically backported this PR to "38-x-y", please check out #47733 |
georgexu99
pushed a commit
that referenced
this pull request
Jul 16, 2025
* build: cleanup symlinks in cache * build: ignore broken links * try --ignore-failed-read * build: dont deref symlinks * build: add flag to 7zip to resolve symlink error Needed to ignore Dangerous symbolic link path was ignored errors * Revert "build: cleanup symlinks in cache" This reverts commit 69e53cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes the issue we are seeing on Windows builds:
Dangerous symbolic link path was ignoredChecklist
npm testpassesRelease Notes
Notes: none