Skip to content

test: cleanup RenderFrame lifespan tests #47746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
+6 −3
Merged

test: cleanup RenderFrame lifespan tests #47746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb519d
test: cleanup RenderFrame lifespan tests
jkleinsc Jul 14, 2025
46e4e17
test: disable navigator.serial tests on arm64 mac
jkleinsc Jul 14, 2025
6a65521
test: add waitUntil for flaky test
jkleinsc Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion spec/api-web-frame-main-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ describe('webFrameMain module', () => {
beforeEach(async () => {
w = new BrowserWindow({ show: false });
});
afterEach(closeAllWindows);

// TODO(jkleinsc) fix this flaky test on linux
ifit(process.platform !== 'linux')('throws upon accessing properties when disposed', async () => {
Expand Down Expand Up @@ -373,7 +374,9 @@ describe('webFrameMain module', () => {
await w.webContents.loadURL(server.crossOriginUrl);
// senderFrame now points to a disposed RenderFrameHost. It should
// be null when attempting to access the lazily evaluated property.
expect(event.senderFrame).to.be.null();
waitUntil(() => {
return event.senderFrame === null;
});
});

it('is detached when unload handler sends IPC', async () => {
Expand Down
4 changes: 2 additions & 2 deletions spec/chromium-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3106,7 +3106,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
});
});

describe('navigator.serial', () => {
ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.serial', () => {
let w: BrowserWindow;
before(async () => {
w = new BrowserWindow({
Expand Down Expand Up @@ -3638,7 +3638,7 @@ ifdescribe((process.platform !== 'linux' || app.isUnityRunning()))('navigator.se
});
});

describe('navigator.bluetooth', () => {
ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.bluetooth', () => {
let w: BrowserWindow;
before(async () => {
w = new BrowserWindow({
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy