Skip to content

feat: enforce unique window names across BaseWindow and BrowserWindow #47764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gsoc-2025
Choose a base branch
from
Open

feat: enforce unique window names across BaseWindow and BrowserWindow #47764

wants to merge 3 commits into from
+84 −4

Conversation

nilayarya
Copy link
Contributor

@nilayarya nilayarya commented Jul 15, 2025 •
edited
Loading

Description of Change

Note

This PR is part of GSoC 2025 [project] [rfc]

This PR adds validation to ensure BaseWindow and BrowserWindow instances cannot be created with duplicate names.

Checklist

Release Notes

Notes: Added validation to ensure BaseWindow and BrowserWindow instances have unique names.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 15, 2025
@nilayarya nilayarya changed the title Unique name feat: enforce unique window names across BaseWindow and BrowserWindow Jul 15, 2025
@nilayarya nilayarya marked this pull request as draft July 15, 2025 22:48
@nilayarya nilayarya marked this pull request as ready for review July 16, 2025 01:47
@nilayarya nilayarya requested review from a team as code owners July 16, 2025 14:16
github-actions[bot]
github-actions bot previously requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nilayarya! It looks like this pull request touches one of our dependency files, and per our contribution policy we do not accept these types of changes in PRs.

@nilayarya nilayarya marked this pull request as draft July 16, 2025 14:18
@georgexu99 georgexu99 force-pushed the unique-name branch 2 times, most recently from 49dc185 to 86d3436 Compare July 16, 2025 16:21
@nilayarya nilayarya marked this pull request as ready for review July 16, 2025 16:26
@georgexu99 georgexu99 added no-backport GSoC 2025 Google Summer of Code 2025 backport-check-skip Skip trop's backport validity checking labels Jul 16, 2025
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Jul 16, 2025
@georgexu99 georgexu99 added the semver/minor backwards-compatible functionality label Jul 17, 2025
@dsanders11 dsanders11 removed request for a team July 23, 2025 15:54
@nilayarya
Copy link
Contributor Author

cc: @VerteDinde @georgexu99 @erickzhao @dsanders11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
backport-check-skip Skip trop's backport validity checking GSoC 2025 Google Summer of Code 2025 no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilayarya @erickzhao @georgexu99
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy