Skip to content

build(dev-deps): drop unused @types/webpack dep #47767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

build(dev-deps): drop unused @types/webpack dep #47767

merged 1 commit into from
Jul 17, 2025
+1 −11

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jul 16, 2025 •
edited
Loading

Description of Change

These days the webpack packages comes with its own types, and @types/webpack@^5.0.0 is just a passthrough for those types, so it can be safely removed.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 16, 2025
@dsanders11 dsanders11 force-pushed the build/drop-webpack-types branch from 4d5e77c to db26e6e Compare July 16, 2025 06:31
@dsanders11 dsanders11 changed the title build(dev-deps): drop unused @types/webpack{-env} deps build(dev-deps): drop unused @types/webpack dep Jul 16, 2025
@dsanders11 dsanders11 marked this pull request as ready for review July 16, 2025 07:03
@dsanders11 dsanders11 added target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 16, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 17, 2025
@codebytere codebytere merged commit bf51d34 into main Jul 17, 2025
113 of 116 checks passed
@codebytere codebytere deleted the build/drop-webpack-types branch July 17, 2025 09:04
@release-clerk
Copy link

release-clerk bot commented Jul 17, 2025

No Release Notes

This was referenced Jul 17, 2025
Open
Merged
Open
Merged
@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I have automatically backported this PR to "35-x-y", please check out #47806

@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I have automatically backported this PR to "36-x-y", please check out #47807

@trop trop bot added in-flight/35-x-y in-flight/36-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Jul 17, 2025
@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I have automatically backported this PR to "37-x-y", please check out #47808

@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I have automatically backported this PR to "38-x-y", please check out #47809

@trop trop bot added in-flight/37-x-y in-flight/38-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Jul 17, 2025
@trop trop bot added merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/36-x-y in-flight/38-x-y labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
in-flight/35-x-y in-flight/37-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsanders11 @codebytere
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy