(DRF 3.0) Added missing default style for FileField #2065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch yup! |
|
Taking out After:
|
|
|
||
| {% block input %} | ||
| <input name="{{ field.name }}" type="{{ style.input_type }}" {% if style.placeholder %}placeholder="{{ style.placeholder }}"{% endif %} {% if field.value %}value="{{ field.value }}"{% endif %}> | ||
| {% endblock %} |
There was a problem hiding this comment.
I've avoided block overriding at all costs so far.
Either we can:
- Have
form-controlbe something that's passed to all otherinputfields except file in the context. - Not write
form_controlifstyle.input_type == file. - Go with what you have here, but be explicit rather than using block overriding.
Additionally we need to make the same fix for the vertical and inline styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browsable api forms were missing file inputs for
FileField. This was easily added by including the information inHTMLFormRenderer.default_styleBefore:
After:
