Skip to content

Overriding Field.__deepcopy__ for RegexField #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Overriding Field.__deepcopy__ for RegexField #2617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions rest_framework/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,18 @@ def __init__(self, regex, **kwargs):
validator = RegexValidator(regex, message=self.error_messages['invalid'])
self.validators.append(validator)

def __deepcopy__(self, memo):
# Handling case when regex is not passed in kwargs.
args = self._args[:1] + copy.deepcopy(self._args[1:])
kwargs = dict(self._kwargs)

# deepcopy doesn't work on compiled regex pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it'd instead be simpler to handle all this logic alongside the similar 'validators' special casing in Field.__deepcopy__?

regex = kwargs.pop('regex', None)
kwargs = copy.deepcopy(kwargs)
if regex is not None:
kwargs['regex'] = regex
return self.__class__(*args, **kwargs)


class SlugField(CharField):
default_error_messages = {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy