Skip to content

Fixing a wrong import location #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atombrella
Copy link
Contributor

No description provided.

….contenttypes.fields'

for backwards compatibility, also import from the old location
@carltongibson
Copy link
Collaborator

Hmmm. Curious how this was passing before.

  1. The import should come from rest_framework.compat — where issues of this sort are handled.
  2. This is addressed in Remove Django 1.6 (and Python 2.6) Support #3429 (on the v3.3. branch) if that gets merged.
  3. Run tox -e py27-lint to see/fix the errors there.

@tomchristie
Copy link
Member

Given that it's for test cases, and they're currently passing, the evidence suggests that its okay as it currently is, right?

@carltongibson
Copy link
Collaborator

Yeah, currently just raising a RemovedInDjango19Warning. As I say, fixed in #3429 ;)

@atombrella atombrella deleted the import_fix branch September 24, 2015 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy