Skip to content

Update #3404 - adds deprecated function to track deprecations #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Update #3404 - adds deprecated function to track deprecations #3478

wants to merge 11 commits into from

Conversation

xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Oct 6, 2015

Taking over #3404. Fixes #3372

@carltongibson
Copy link
Collaborator

👍🏽

@xordoquy
Copy link
Collaborator Author

xordoquy commented Oct 6, 2015

@carltongibson sorry for the delay

@carltongibson
Copy link
Collaborator

No worries. 😃

@carltongibson carltongibson mentioned this pull request Oct 7, 2015
Closed
@xordoquy xordoquy mentioned this pull request Oct 22, 2015
Merged
tomchristie
tomchristie reviewed Oct 22, 2015
View reviewed changes
rest_framework/pagination.py
),
DeprecationWarning,
)
deprecated((3, 0, 0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version against this looks wrong, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like, will fix that one and the one under.

@xordoquy
Copy link
Collaborator Author

PR updated

@xordoquy
Copy link
Collaborator Author

Do we really need some coverage or can we merge this ?

@jpadilla
Copy link
Member

LGTM although not sure we might want to take care of #3478 (comment) first.

@xordoquy
Copy link
Collaborator Author

@jpadilla anything in mind on top of https://github.com/tomchristie/django-rest-framework/pull/3478/files#diff-6c2b4517644b3a66478c9c8b63043359R31 ?

@tomchristie
Copy link
Member

Are there currently any places where this should be used as part of the PR?

@xordoquy
Copy link
Collaborator Author

@tomchristie Not sure it's a good thing to make it part of this PR.

@tomchristie
Copy link
Member

@xordoquy Possibly, but be helpful to enumerate 'em either way.

@tomchristie
Copy link
Member

tomchristie commented Oct 11, 2016 •
edited by kevin-brown
Loading

On revisiting this, I'm not convinced we need this wrapper. Managing deprecations hasn't been a pain point for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xordoquy @carltongibson @jpadilla @tomchristie
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy