Allowed Field to specify their own metadata. #4022
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first commit adds regression tests for the existing metadata generation through
SimpleMetadata
.The second one adds a
get_metadata()
method to theField
class in order to allow fields to specify their own metadata. Backward compatibility is maintained and theSimpleMetadata
's API is unchanged, it simply delegates toField.get_metadata()
.This is a change required in order to offer a backward compatible deprecation path for #4021.