-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add failing test for issue #4073 #4074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re base
Yikes 👀 . Been punting on this one for a while now... Aside @auvipy: Probably better to refrain from pitching in asking contributors to rebase, particularly given that the ticket's remained inactive for so long. |
That seems right, but we still need to settle what the appropriate response is here. I'm going to de-milestone for now. |
It looks like this has been fixed at some point. Is it worth it to clean up the test case (eg, check what the expected behavior should be, instead of just not failing) and add it to the test suite? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
that would be the right approach FMPOV. also the test seems to have lots of conflicts to resolve. I will try to investigate and try this test freshly |
Why make work? |
Description
Adds failing test for issue #4073.
refs #4073