Skip to content

Add failing test for issue #4073 #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexcreid
Copy link

Description

Adds failing test for issue #4073.

refs #4073

@tomchristie tomchristie added this to the 3.4.6 Release milestone Aug 19, 2016
@tomchristie tomchristie modified the milestones: 3.4.7 Release, 3.4.8 Release Sep 21, 2016
@tomchristie tomchristie modified the milestones: 3.4.8 Release, 3.5.0 Release, 3.5.1 Release Oct 10, 2016
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re base

@tomchristie
Copy link
Member

tomchristie commented Apr 27, 2017

Yikes 👀 . Been punting on this one for a while now...

image

Aside @auvipy: Probably better to refrain from pitching in asking contributors to rebase, particularly given that the ticket's remained inactive for so long.

@carltongibson
Copy link
Collaborator

It's not entirely clear to me what the behaviour should be where a nested serialiser has a list of errors rather than a dictionary, but it probably shouldn't be to error out.

That seems right, but we still need to settle what the appropriate response is here.

I'm going to de-milestone for now.

@rpkilby
Copy link
Member

rpkilby commented May 20, 2018

It looks like this has been fixed at some point. Is it worth it to clean up the test case (eg, check what the expected behavior should be, instead of just not failing) and add it to the test suite?

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 13, 2022
@auvipy
Copy link
Member

auvipy commented Nov 24, 2022

It looks like this has been fixed at some point. Is it worth it to clean up the test case (eg, check what the expected behavior should be, instead of just not failing) and add it to the test suite?

that would be the right approach FMPOV. also the test seems to have lots of conflicts to resolve. I will try to investigate and try this test freshly

@stale stale bot removed the stale label Nov 24, 2022
@tomchristie
Copy link
Member

that would be the right approach FMPOV. also the test seems to have lots of conflicts to resolve. I will try to investigate and try this test freshly

Why make work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy