-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix #4965 #4966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4965 #4966
Conversation
Looks promising! Want to include before/after screenshots to this thread, based on the description in #4965? |
I can confirm that this works for our API, where everything is nested below |
I'll try to add screenshots tonight |
Took a first pass review over this, but I'm going to need to come back to it at a later time, since it's quite a large footprint. |
Thanks for this PR. I've had similar issue and the code helped a lot! However, I have a suggestion for the
Consider doing this:
In my case, I have a viewset with a nested route that essentially looks like this:
(I have a hacked SchemaGenerator.get_links to mess with the follow's The problem is, at the same odict level there are both links ( |
Just noticed one thing. I haven't checked the HTML spec, but it seems that code like Maybe it would be smarter to have prefixes as lists or tuples rather than strings. |
Thanks for the input here. We've gone with #5334 in the end. |
This PR fixes #4965 by adding recursive-enabled menu-tree and well as recursive-enabled documentation. It also makes sure that code-snippets and interact dialog are working with multi-level document (by using a new templatetag)