Fixes #5172 Fix curly bracket in regexp of @list_route #5177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@auvipy Seems it doesn't work when I only escape brackets (maybe). I glad to work on it this weekend. |
|
Going to close this off in its current state as it's not sufficiently clear what the intent is or why this does/doesn't fix anything. More than happy to consider a subsequent PR will a clearer rational or test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5172
if url_path contains curly brackets, these raise error while url_path.format() .
ex.
'{router_url}/(?P<year>[0-9]{4}){trailing_slash}'.format(router_url='some_url', trailing_slash='/'){4} inside regex raise IndexError
so it need to replace single curly bracket to double.