Skip to content

Binding child should happen in bind no init #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -563,10 +563,10 @@ def __init__(self, *args, **kwargs):
assert self.child is not None, '`child` is a required argument.'
assert not inspect.isclass(self.child), '`child` has not been instantiated.'
super(ListSerializer, self).__init__(*args, **kwargs)
self.child.bind(field_name='', parent=self)

def bind(self, field_name, parent):
super(ListSerializer, self).bind(field_name, parent)
self.child.bind(field_name='', parent=self)
self.partial = self.parent.partial

def get_initial(self):
Expand Down
62 changes: 62 additions & 0 deletions tests/test_root.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
from __future__ import unicode_literals

from django.test import TestCase, override_settings

from rest_framework import serializers


class ChildSerializer(serializers.Serializer):
def __init__(self, *args, **kwargs):
super().__init__(self, *args, **kwargs)
# Not calling self.root

def to_internal_value(self, data):
value = super().to_internal_value(data)
value['root'] = self.root
return value


class AnotherChildSerializer(serializers.Serializer):
def __init__(self, *args, **kwargs):
super().__init__(self, *args, **kwargs)
self.root # Calling self.root to ruin the cache

def to_internal_value(self, data):
value = super().to_internal_value(data)
value['root'] = self.root
return value


class ParentSerializer(serializers.Serializer):
children = ChildSerializer(many=True)
other_children = AnotherChildSerializer(many=True)

def __init__(self, *args, **kwargs):
super().__init__(self, *args, **kwargs)
# Not calling self.root

def to_internal_value(self, data):
value = super().to_internal_value(data)
value['root'] = self.root
return value


class RootSerializer(serializers.Serializer):
parents = ParentSerializer(many=True)


class ListManyToManyTests(TestCase):
def setUp(self):
self.root = RootSerializer(data={
'parents': [{
'children': [{'name': 'child'}],
'other_children': [{'name': 'child'}],
}],
})
self.root.is_valid()

def test_relative_hyperlinks(self):
assert self.root.root == self.root
assert self.root.validated_data['parents'][0]['root'] == self.root
assert self.root.validated_data['parents'][0]['children'][0]['root'] == self.root
assert self.root.validated_data['parents'][0]['other_children'][0]['root'] == self.root
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy