replaced '.' for '__' in dotted ordering sources #5525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
requested changes
Oct 25, 2017
| @@ -199,7 +199,7 @@ def get_default_valid_fields(self, queryset, view, context={}): | |||
| raise ImproperlyConfigured(msg % self.__class__.__name__) | |||
|
|
|||
| return [ | |||
| (field.source or field_name, field.label) | |||
| (field.source.replace('.', '__') or field_name, field.label) | |||
There was a problem hiding this comment.
source defaults to None, so I'm worried we'll get an error here.
>>> None.replace('.', '__')
AttributeError: 'NoneType' object has no attribute 'replace'
| class OrderingDottedRelatedSerializer(serializers.ModelSerializer): | ||
| related_text = serializers.CharField(source='related_object.text') | ||
| related_title = serializers.CharField(source='related_object.title') | ||
|
|
There was a problem hiding this comment.
I think we need an additional field here not setting the source to test.
|
@OmegaDroid I added a test covering my concern in #5533. tl;dr: no issue. Thanks for the input! Great stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into an issue the other day where a serializer referring to a field in a related object didn't provide the correct field name for the ordering filter backend.
Updating the
get_default_valid_fieldsmethod so that for dotted sources the.for__fixes my use case.