Skip to content

routers: invalidate _urls cache on register #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rest_framework/routers.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ def register(self, prefix, viewset, basename=None, base_name=None):
basename = self.get_default_basename(viewset)
self.registry.append((prefix, viewset, basename))

# invalidate the urls cache
if hasattr(self, '_urls'):
del self._urls

def get_default_basename(self, viewset):
"""
If `basename` is not specified, attempt to automatically determine
Expand Down
6 changes: 6 additions & 0 deletions tests/test_routers.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ def test_multiple_action_handlers(self):
response = self.client.delete(reverse('basic-action3', args=[1]))
assert response.data == {'delete': '1'}

def test_register_after_accessing_urls(self):
self.router.register(r'notes', NoteViewSet)
assert len(self.router.urls) == 2 # list and detail
self.router.register(r'notes_bis', NoteViewSet)
assert len(self.router.urls) == 4


class TestRootView(URLPatternsTestCase, TestCase):
urlpatterns = [
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy