Skip to content

Fix infinite recursion with deepcopy on Request #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rest_framework/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ def __getattr__(self, attr):
to proxy it to the underlying HttpRequest object.
"""
try:
return getattr(self._request, attr)
_request = self.__getattribute__("_request")
return getattr(_request, attr)
except AttributeError:
return self.__getattribute__(attr)

Expand Down
8 changes: 8 additions & 0 deletions tests/test_request.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
Tests for content parsing, and form-overloaded content parsing.
"""
import copy
import os.path
import tempfile

Expand Down Expand Up @@ -344,3 +345,10 @@ def test_duplicate_request_form_data_access(self):
# ensure that request stream was consumed by form parser
assert request.content_type.startswith('multipart/form-data')
assert response.data == {'a': ['b']}


class TestDeepcopy(TestCase):

def test_deepcopy_works(self):
request = Request(factory.get('/', secure=False))
copy.deepcopy(request)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy