Skip to content

docs: rewrite using let and const in rule examples #19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 9, 2025
Merged

docs: rewrite using let and const in rule examples #19320

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
82002be
docs: rewrite var using let and const
PoloSpark Jan 6, 2025
e1fc896
docs: rewrite examples using let and const
PoloSpark Jan 6, 2025
772beb0
Merge branch 'main' into main
PoloSpark Jan 7, 2025
c0879d8
docs: rewrite var using let and const
PoloSpark Jan 7, 2025
74b5ac4
Update docs/src/rules/accessor-pairs.md
PoloSpark Jan 7, 2025
8087bd2
Update docs/src/rules/accessor-pairs.md
PoloSpark Jan 7, 2025
f393ab1
docs: rewrite using const
PoloSpark Jan 7, 2025
bba35fd
Merge branch 'main' of https://github.com/PoloSpark/eslint
PoloSpark Jan 7, 2025
a1985d1
Update accessor-pairs.md
PoloSpark Jan 7, 2025
f2495f5
Update accessor-pairs.md
PoloSpark Jan 9, 2025
2f7af03
Update let variables to const
PoloSpark Jan 9, 2025
a7fb4ac
Merge branch 'main' into main
PoloSpark Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions docs/src/rules/accessor-pairs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ Here are some examples:

```js
// Bad
var o = {
const o = {
set a(value) {
this.val = value;
}
};


// Good
var o = {
const p = {
set a(value) {
this.val = value;
},
Expand Down Expand Up @@ -61,15 +61,15 @@ Examples of **incorrect** code for the default `{ "setWithoutGet": true }` optio
```js
/*eslint accessor-pairs: "error"*/

var o = {
const q = {
set a(value) {
this.val = value;
}
};


var o = {d: 1};
Object.defineProperty(o, 'c', {
const r = {d: 1};
Object.defineProperty(r, 'c', {
set: function(value) {
this.val = value;
}
Expand All @@ -85,7 +85,7 @@ Examples of **correct** code for the default `{ "setWithoutGet": true }` option:
```js
/*eslint accessor-pairs: "error"*/

var o = {
const s = {
set a(value) {
this.val = value;
},
Expand All @@ -94,8 +94,8 @@ var o = {
}
};

var o = {d: 1};
Object.defineProperty(o, 'c', {
const t = {d: 1};
Object.defineProperty(t, 'c', {
set: function(value) {
this.val = value;
},
Expand All @@ -117,27 +117,27 @@ Examples of **incorrect** code for the `{ "getWithoutSet": true }` option:
```js
/*eslint accessor-pairs: ["error", { "getWithoutSet": true }]*/

var o = {
const u = {
set a(value) {
this.val = value;
}
};

var o = {
const v = {
get a() {
return this.val;
}
};

var o = {d: 1};
Object.defineProperty(o, 'c', {
const w = {d: 1};
Object.defineProperty(w, 'c', {
set: function(value) {
this.val = value;
}
});

var o = {d: 1};
Object.defineProperty(o, 'c', {
const x = {d: 1};
Object.defineProperty(x, 'c', {
get: function() {
return this.val;
}
Expand All @@ -152,7 +152,7 @@ Examples of **correct** code for the `{ "getWithoutSet": true }` option:

```js
/*eslint accessor-pairs: ["error", { "getWithoutSet": true }]*/
var o = {
const y = {
set a(value) {
this.val = value;
},
Expand All @@ -161,8 +161,8 @@ var o = {
}
};

var o = {d: 1};
Object.defineProperty(o, 'c', {
const z = {d: 1};
Object.defineProperty(z, 'c', {
set: function(value) {
this.val = value;
},
Expand Down Expand Up @@ -281,14 +281,14 @@ might not report a missing pair for a getter/setter that has a computed key, lik
```js
/*eslint accessor-pairs: "error"*/

var a = 1;
const z = 1;

// no warnings
var o = {
get [a++]() {
const a = {
get [z++]() {
return this.val;
},
set [a++](value) {
set [z++](value) {
this.val = value;
}
};
Expand All @@ -301,7 +301,7 @@ might not report a missing pair for a getter/setter, like in the following examp
/*eslint accessor-pairs: "error"*/

// no warnings
var o = {
const b = {
get a() {
return this.val;
},
Expand Down
120 changes: 60 additions & 60 deletions docs/src/rules/array-bracket-newline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ Examples of **incorrect** code for this rule with the `"always"` option:
```js
/*eslint array-bracket-newline: ["error", "always"]*/

var a = [];
var b = [1];
var c = [1, 2];
var d = [1,
let a = [];
let b = [1];
let c = [1, 2];
let d = [1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let a = [];
let b = [1];
let c = [1, 2];
let d = [1,
const a = [];
const b = [1];
const c = [1, 2];
const d = [1,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in all places in the array-backet-newline.md file also.

2];
var e = [function foo() {
let e = [function foo() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let e = [function foo() {
const e = [function foo() {

dosomething();
}];
```
Expand All @@ -54,19 +54,19 @@ Examples of **correct** code for this rule with the `"always"` option:
```js
/*eslint array-bracket-newline: ["error", "always"]*/

var a = [
let a = [
];
var b = [
let b = [
1
];
var c = [
let c = [
1, 2
];
var d = [
let d = [
1,
2
];
var e = [
let e = [
function foo() {
dosomething();
}
Expand All @@ -84,19 +84,19 @@ Examples of **incorrect** code for this rule with the `"never"` option:
```js
/*eslint array-bracket-newline: ["error", "never"]*/

var a = [
let a = [
];
var b = [
let b = [
1
];
var c = [
let c = [
1, 2
];
var d = [
let d = [
1,
2
];
var e = [
let e = [
function foo() {
dosomething();
}
Expand All @@ -112,12 +112,12 @@ Examples of **correct** code for this rule with the `"never"` option:
```js
/*eslint array-bracket-newline: ["error", "never"]*/

var a = [];
var b = [1];
var c = [1, 2];
var d = [1,
let a = [];
let b = [1];
let c = [1, 2];
let d = [1,
2];
var e = [function foo() {
let e = [function foo() {
dosomething();
}];
```
Expand All @@ -133,15 +133,15 @@ Examples of **incorrect** code for this rule with the `"consistent"` option:
```js
/*eslint array-bracket-newline: ["error", "consistent"]*/

var a = [1
let a = [1
];
var b = [
let b = [
1];
var c = [function foo() {
let c = [function foo() {
dosomething();
}
]
var d = [
let d = [
function foo() {
dosomething();
}]
Expand All @@ -156,17 +156,17 @@ Examples of **correct** code for this rule with the `"consistent"` option:
```js
/*eslint array-bracket-newline: ["error", "consistent"]*/

var a = [];
var b = [
let a = [];
let b = [
];
var c = [1];
var d = [
let c = [1];
let d = [
1
];
var e = [function foo() {
let e = [function foo() {
dosomething();
}];
var f = [
let f = [
function foo() {
dosomething();
}
Expand All @@ -184,17 +184,17 @@ Examples of **incorrect** code for this rule with the default `{ "multiline": tr
```js
/*eslint array-bracket-newline: ["error", { "multiline": true }]*/

var a = [
let a = [
];
var b = [
let b = [
1
];
var c = [
let c = [
1, 2
];
var d = [1,
let d = [1,
2];
var e = [function foo() {
let e = [function foo() {
dosomething();
}];
```
Expand All @@ -208,14 +208,14 @@ Examples of **correct** code for this rule with the default `{ "multiline": true
```js
/*eslint array-bracket-newline: ["error", { "multiline": true }]*/

var a = [];
var b = [1];
var c = [1, 2];
var d = [
let a = [];
let b = [1];
let c = [1, 2];
let d = [
1,
2
];
var e = [
let e = [
function foo() {
dosomething();
}
Expand All @@ -233,15 +233,15 @@ Examples of **incorrect** code for this rule with the `{ "minItems": 2 }` option
```js
/*eslint array-bracket-newline: ["error", { "minItems": 2 }]*/

var a = [
let a = [
];
var b = [
let b = [
1
];
var c = [1, 2];
var d = [1,
let c = [1, 2];
let d = [1,
2];
var e = [
let e = [
function foo() {
dosomething();
}
Expand All @@ -257,16 +257,16 @@ Examples of **correct** code for this rule with the `{ "minItems": 2 }` option:
```js
/*eslint array-bracket-newline: ["error", { "minItems": 2 }]*/

var a = [];
var b = [1];
var c = [
let a = [];
let b = [1];
let c = [
1, 2
];
var d = [
let d = [
1,
2
];
var e = [function foo() {
let e = [function foo() {
dosomething();
}];
```
Expand All @@ -282,15 +282,15 @@ Examples of **incorrect** code for this rule with the `{ "multiline": true, "min
```js
/*eslint array-bracket-newline: ["error", { "multiline": true, "minItems": 2 }]*/

var a = [
let a = [
];
var b = [
let b = [
1
];
var c = [1, 2];
var d = [1,
let c = [1, 2];
let d = [1,
2];
var e = [function foo() {
let e = [function foo() {
dosomething();
}];
```
Expand All @@ -304,16 +304,16 @@ Examples of **correct** code for this rule with the `{ "multiline": true, "minIt
```js
/*eslint array-bracket-newline: ["error", { "multiline": true, "minItems": 2 }]*/

var a = [];
var b = [1];
var c = [
let a = [];
let b = [1];
let c = [
1, 2
];
var d = [
let d = [
1,
2
];
var e = [
let e = [
function foo() {
dosomething();
}
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy