-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: add allowSeparateTypeImports
option to no-duplicate-imports
#19872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a note on the docs to make things clearer.
Would like another review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving it open until tomorrow (2 days waiting period per our policies) to allow others to review it if they want before merging.
allowSeparateTypeImports
option to no-duplicate-imports
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added a new allowSeparateTypeImports option to the no-duplicate-imports rule that allows a type import alongside a value import from the same module in TypeScript files.
Closes #19834
Is there anything you'd like reviewers to focus on?