Skip to content

Minimal EthereumJS Website Update #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Minimal EthereumJS Website Update #11

merged 4 commits into from
Aug 2, 2023

Conversation

holgerd77
Copy link
Member

This updates the https://ethereumjs.github.io/ EthereumJS website on a basic level by adopting to our current project structure, rewriting some intro texts and generally weighting things more according our current priorities.

This is how the site now renders:

grafik grafik

Open for review. 🙂

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and most of my comments are nits, (except the bit about a missing reference to the evm package and LES protocol in devp2p).

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks great, except that we do not mention these packages:

  • Common
  • (Ethash)
  • Evm
  • Genesis

I think these three packages should be added.

@holgerd77
Copy link
Member Author

I think this all looks great, except that we do not mention these packages:

* Common

* (Ethash)

* Evm

* Genesis

I think these three packages should be added.

Already wrote this in a reply to Andrew, I rather would not want this to just make this a complete package list but rather - team-subjectively - focus on the most important stuff we are doing and put this a bit more in the spotlight (I explicitly wanted to get away from this old version a bit, which was just a long and undifferentiated package list with geth.js (lol) side by side with our VM).

So for all mentioned libraries I would have some tendency not to take:

* Common

This library is rather not so exciting on its own, so not that much of a "teaser" library

* (Ethash)

What's that? 😂

* Evm

As answered in the response to Andrews question.

* Genesis

Not an interesting package on its own.

@holgerd77
Copy link
Member Author

Also, maybe to mention, this is somewhat in contrast to our monorepo README entrypoint, where just every package is listed in this long table: https://github.com/ethereumjs/ethereumjs-monorepo

Didn't want to just reproduce this.

@holgerd77
Copy link
Member Author

Ready for re-review. 🙂

@holgerd77
Copy link
Member Author

Ok, ready for re-review. 🙂

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holgerd77 holgerd77 merged commit 8a96fc8 into master Aug 2, 2023
@holgerd77 holgerd77 deleted the website-update branch August 2, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy