Skip to content

Update website #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 19, 2018
Merged

Update website #4

merged 8 commits into from
Mar 19, 2018

Conversation

holgerd77
Copy link
Member

Adresses #3

@holgerd77 holgerd77 changed the title [WIP] Update website Update website Jan 24, 2018
@holgerd77 holgerd77 requested a review from axic January 24, 2018 12:13
@holgerd77
Copy link
Member Author

Ok, this is now ready. Since this is awful to review by code, I did a little fork deployment at https://holgerd77.github.io/ethereumjs.github.io/.

Only working half though, since reading metadata from this context is not working properly. Nevertheless, should give an impression.

Properly deployed site should look a bit like:

bildschirmfoto 2018-01-24 um 13 15 25

All projects now use the metadata description from GitHub and there is a single repository.html template we can easily expand from later (I couldn't e.g. include the latest release version number - which I originally wanted to do - since this was more complex than I thought).

I also removed outdated repositories, brought some structure to everything and updated the texts.

@axic
Copy link
Member

axic commented Jan 24, 2018

Looks nice!

But I think the grouping is really bad. Please keep a note of the grouping in the old version.

For example:

  • ethereumjs-account has nothing to do with key management, it is a blockchain related repo
  • ethereumjs-wallet and keythereum are the only real key management ones, but I'd put helpeth there too
  • abi and tx should really not have much to do with blockchain and block
  • wallet/units/icap do not have anything in common with mining
  • ethrpc shouldn't be next to devp2p
  • common isn't really a useful utility, it is internal to the vm/blockchain

Some proposed categories:

  • Key management (wallet, keyethereum, icap, helpeth)
  • Dapp development (ethrpc, util, units, abi, tx)
  • VM
  • devp2p / node

@holgerd77
Copy link
Member Author

Ok. Will give it another try. :-)

@axic
Copy link
Member

axic commented Jan 24, 2018

Do you want to pull out the other commits (apart from the last two) and merge those right now? (Those only do reorganisations and build improvements).

@holgerd77
Copy link
Member Author

Hmm, I didn't commit in chronological work order, this most-for-sure won't work. I'll try another reorg and squash the commit.

@holgerd77
Copy link
Member Author

Ok, done, went pretty much along the lines you suggested.

@holgerd77
Copy link
Member Author

Is this mergeable now?

I think this should make more sense now and we won't find a perfect taxonomy anyway. This is just for giving people some basic orientation when they are looking for stuff.

@holgerd77
Copy link
Member Author

(I also didn't remove any old grouping, there actually wasn't any except from a alphabetical list: https://ethereumjs.github.io/)

@holgerd77
Copy link
Member Author

@axic Is this stuck due to you being not satisfied with sorting this into some kind of categories or just for no-time-to-review reasons?

@axic
Copy link
Member

axic commented Jan 31, 2018

No time, should have time this week.

@holgerd77
Copy link
Member Author

Can this be merged at some point? It's a bit unsatisfying to get stuck with this super-outdated website while this is in the pipeline.

Should also rather be a starting then an endpoint, since people can now easier/directly update the website with simple PRs, so we can slowly evolve and (hopefully) get this updated/enhanced a bit more frequently.

@holgerd77
Copy link
Member Author

Hi @axic, can you do a short other look at the new groupings here? Really just a few lines in index.md to review. 😄

@holgerd77 holgerd77 merged commit de236f3 into master Mar 19, 2018
@holgerd77 holgerd77 deleted the update-website branch March 19, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy