Fix empty attribute crash in DataChannelRereader2 #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
3c3545f to
1a18470
Compare
|
NACK to |
1a18470 to
6ddcaf9
Compare
6ddcaf9 to
f356d8b
Compare
jabrena
reviewed
Jan 3, 2021
| throw new IOException("Premature end of file "); | ||
| } | ||
| } while (n <= 0); | ||
| byteBuffer.clear(); |
There was a problem hiding this comment.
@JakubVanek, restore the original code. Allow people develop the ideas
There was a problem hiding this comment.
this seems to be already fixed (i usually rewrite git history using git rebase -i to have clean commit sequences)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the issue described in #765 (comment) for DCR2. DCR1 should already be fixed from #778.